Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync mobile and import views improvements #3282

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Sync mobile and import views improvements #3282

merged 8 commits into from
Nov 26, 2024

Conversation

submarcos
Copy link
Member

@submarcos submarcos commented Oct 6, 2022

improve display and progress bars from sync and import views after bootstrap4 update

@submarcos submarcos changed the title Sync view Sync and import views improvments Oct 6, 2022
@cypress
Copy link

cypress bot commented Oct 6, 2022

Geotrek-admin    Run #10458

Run Properties:  status check passed Passed #10458  •  git commit 9c8991b1b3 ℹ️: Merge 96e8b130afa79a5fcdabbcd0082ac15fa47d313d into b56d58f47bc510eb8ecf55ac549f...
Project Geotrek-admin
Branch Review refs/pull/3282/merge
Run status status check passed Passed #10458
Run duration 02m 07s
Commit git commit 9c8991b1b3 ℹ️: Merge 96e8b130afa79a5fcdabbcd0082ac15fa47d313d into b56d58f47bc510eb8ecf55ac549f...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@@ -936,6 +936,7 @@ In preparation for HD Views developments (PR #3298)

- Show direction on lines with setting ``DIRECTION_ON_LINES_ENABLED`` in signage detail
- Add mobile nginx configuration directly on Geotrek-admin
- Improve sync rando, sync mobile and import views.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Improve sync rando, sync mobile and import views.

@submarcos submarcos changed the title Sync and import views improvments Sync mobile and import views improvements Nov 26, 2024
@submarcos submarcos marked this pull request as ready for review November 26, 2024 15:46
@submarcos submarcos merged commit 76d225d into master Nov 26, 2024
19 checks passed
@submarcos submarcos deleted the sync_view branch November 26, 2024 15:46
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (b56d58f) to head (96e8b13).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   98.45%   98.45%   -0.01%     
==========================================
  Files         267      267              
  Lines       21107    21106       -1     
==========================================
- Hits        20781    20780       -1     
  Misses        326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants